netdev - Re: [net V2 07/15] net/mlx5: Fix request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e66e2680-cef2-b662-45f6-4c31616d3934@nvidia.com>
Date:   Fri, 2 Oct 2020 10:19:01 -0700
From:   Mark Bloch <mbloch@...dia.com>
To:     Saeed Mahameed <saeed@...nel.org>, Jakub Kicinski <kuba@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Maor Gottlieb <maorg@...dia.com>,
        Eran Ben Elisha <eranbe@...dia.com>
Subject: Re: [net V2 07/15] net/mlx5: Fix request_irqs error flow



On 10/2/2020 10:05, Saeed Mahameed wrote:
> On Thu, 2020-10-01 at 16:24 -0700, Jakub Kicinski wrote:
>> On Thu,  1 Oct 2020 12:52:39 -0700 saeed@...nel.org wrote:
>>> -	for (; i >= 0; i--) {
>>> +	for (--i; i >= 0; i--) {
>>
>> while (i--)
> 
> while(--i)

It has to be: while (i--)
Case of i=0,

> 
> I like this, less characters to maintain :)
> 

Mark