netdev - Re: [net V2 07/15] net/mlx5: Fix request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f50ceebd886f5b083a918e57fdbe0c26024c0f17.camel@kernel.org>
Date:   Fri, 02 Oct 2020 10:27:22 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Mark Bloch <mbloch@...dia.com>, Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Maor Gottlieb <maorg@...dia.com>,
        Eran Ben Elisha <eranbe@...dia.com>
Subject: Re: [net V2 07/15] net/mlx5: Fix request_irqs error flow

On Fri, 2020-10-02 at 10:19 -0700, Mark Bloch wrote:
> 
> On 10/2/2020 10:05, Saeed Mahameed wrote:
> > On Thu, 2020-10-01 at 16:24 -0700, Jakub Kicinski wrote:
> > > On Thu,  1 Oct 2020 12:52:39 -0700 saeed@...nel.org wrote:
> > > > -	for (; i >= 0; i--) {
> > > > +	for (--i; i >= 0; i--) {
> > > 
> > > while (i--)
> > 
> > while(--i)
> 
> It has to be: while (i--)
> Case of i=0,
> 

woops !

while (i--) it is. 

Thanks Mark.