lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Oct 2020 01:08:24 -0300 From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com> To: kernel test robot <lkp@...el.com> Cc: Xin Long <lucien.xin@...il.com>, network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org, kbuild-all@...ts.01.org, Neil Horman <nhorman@...driver.com>, Michael Tuexen <tuexen@...muenster.de>, Tom Herbert <therbert@...gle.com>, davem@...emloft.net Subject: Re: [PATCH net-next 11/15] sctp: add udphdr to overhead when udp_port is set On Wed, Sep 30, 2020 at 03:00:42AM +0800, kernel test robot wrote: > Hi Xin, > > Thank you for the patch! Yet something to improve: I wonder how are you planning to fix this. It is quite entangled. This is not performance critical. Maybe the cleanest way out is to move it to a .c file. Adding a #if defined(CONFIG_IP_SCTP) || defined(CONFIG_IP_SCTP_MODULE) in there doesn't seem good. > In file included from include/net/sctp/checksum.h:27, > from net/netfilter/nf_nat_proto.c:16: > include/net/sctp/sctp.h: In function 'sctp_mtu_payload': > >> include/net/sctp/sctp.h:583:31: error: 'struct net' has no member named 'sctp'; did you mean 'ct'? > 583 | if (sock_net(&sp->inet.sk)->sctp.udp_port) > | ^~~~ > | ct >
Powered by blists - more mailing lists