netdev - Re: [PATCH net-next 12/15] sctp: call sk_setup_caps in sctp_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201003040915.GH70998@localhost.localdomain>
Date:   Sat, 3 Oct 2020 01:09:15 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>,
        Michael Tuexen <tuexen@...muenster.de>,
        Tom Herbert <therbert@...gle.com>, davem@...emloft.net
Subject: Re: [PATCH net-next 12/15] sctp: call sk_setup_caps in
 sctp_packet_transmit instead

On Tue, Sep 29, 2020 at 09:49:04PM +0800, Xin Long wrote:
> sk_setup_caps() was originally called in Commit 90017accff61 ("sctp:
> Add GSO support"), as:
> 
>   "We have to refresh this in case we are xmiting to more than one
>    transport at a time"
> 
> This actually happens in the loop of sctp_outq_flush_transports(),
> and it shouldn't be gso related, so move it out of gso part and

To be more precise, "shouldn't be tied to gso"

> before sctp_packet_pack().