netdev - Re: [PATCH net-next] net: dsa: propagate switchdev vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6cf6685-892e-694a-45a1-1c09ece0b086@gmail.com>
Date:   Sun, 4 Oct 2020 20:28:25 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Jonathan McDowell <noodles@...th.li>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [PATCH net-next] net: dsa: propagate switchdev vlan_filtering
 prepare phase to drivers



On 10/2/2020 15:06, Vladimir Oltean wrote:
> A driver may refuse to enable VLAN filtering for any reason beyond what
> the DSA framework cares about, such as:
> - having tc-flower rules that rely on the switch being VLAN-aware
> - the particular switch does not support VLAN, even if the driver does
>    (the DSA framework just checks for the presence of the .port_vlan_add
>    and .port_vlan_del pointers)
> - simply not supporting this configuration to be toggled at runtime
> 
> Currently, when a driver rejects a configuration it cannot support, it
> does this from the commit phase, which triggers various warnings in
> switchdev.
> 
> So propagate the prepare phase to drivers, to give them the ability to
> refuse invalid configurations cleanly and avoid the warnings.
> 
> Since we need to modify all function prototypes and check for the
> prepare phase from within the drivers, take that opportunity and move
> the existing driver restrictions within the prepare phase where that is
> possible and easy.
> 
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Cc: Hauke Mehrtens <hauke@...ke-m.de>
> Cc: Woojung Huh <woojung.huh@...rochip.com>
> Cc: Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>
> Cc: Sean Wang <sean.wang@...iatek.com>
> Cc: Landen Chao <Landen.Chao@...iatek.com>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Vivien Didelot <vivien.didelot@...il.com>
> Cc: Jonathan McDowell <noodles@...th.li>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Claudiu Manoil <claudiu.manoil@....com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Rewieved-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian