lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 4 Oct 2020 17:45:22 -0700
From:   Florian Fainelli <>
To:     Vladimir Oltean <>,
        "" <>,
        "" <>,
        "" <>
Cc:     Martin Blumenstingl <>,
        Hauke Mehrtens <>,
        Woojung Huh <>,
        Microchip Linux Driver Support <>,
        Sean Wang <>,
        Landen Chao <>,
        Andrew Lunn <>,
        Vivien Didelot <>,
        Jonathan McDowell <>,
        Linus Walleij <>,
        Alexandre Belloni <>,
        Claudiu Manoil <>
Subject: Re: [PATCH net-next] net: dsa: propagate switchdev vlan_filtering
 prepare phase to drivers

On 10/4/2020 1:59 PM, Vladimir Oltean wrote:
> On Sat, Oct 03, 2020 at 01:06:46AM +0300, Vladimir Oltean wrote:
> [...]
>> ---
>> The API for this one was chosen to be different than the one for
>> .port_vlan_add and .port_vlan_prepare because
>> (a) the list of dsa_switch_ops is growing bigger but in this case there
>>      is no justification for it. For example there are some drivers that
>>      don't do anything in .port_vlan_prepare, and likewise, they may not
>>      need to do anything in .port_vlan_filtering_prepare either
>> (b) the DSA API should be as close as possible to the switchdev API
>>      except when there's a strong reason for that not to be the case. In
>>      this situation, I don't see why it would be different.
> I understand that this new function prototype is not to everyone's
> taste?

Just need more time to review, have not looked at it yet.

Powered by blists - more mailing lists