netdev - Re: [PATCH bpf-next] selftests/bpf: Additional asm tests for the verifier regalloc tracking.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJxpG4_c3UHQg-KxOxUWSnas-cZvjtA1_VJnbEdnxbEnw@mail.gmail.com>
Date:   Wed, 7 Oct 2020 15:57:13 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        john fastabend <john.fastabend@...il.com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Additional asm tests for the
 verifier regalloc tracking.

On Wed, Oct 7, 2020 at 3:50 PM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Wed, Oct 7, 2020 at 3:28 PM Alexei Starovoitov
> <alexei.starovoitov@...il.com> wrote:
> >
> > From: Alexei Starovoitov <ast@...nel.org>
> >
> > Add asm tests for register allocator tracking logic implemented in the patches:
> > https://lore.kernel.org/bpf/20201006200955.12350-1-alexei.starovoitov@gmail.com/T/#t
> >
> > Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> > ---
>
> I actually read through that assembly :) LGTM.

Thanks. I've added comments to the trickiest case :)

> Acked-by: Andrii Nakryiko <andrii@...nel.org>
>
> >  .../testing/selftests/bpf/verifier/regalloc.c | 159 ++++++++++++++++++
> >  1 file changed, 159 insertions(+)
> >  create mode 100644 tools/testing/selftests/bpf/verifier/regalloc.c
> >
>
> [...]