netdev - Re: net: Initialize return value in gro_cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c6415e4-9d3b-2ba9-494a-c24316ec60c4@gmail.com>
Date:   Wed, 7 Oct 2020 10:21:20 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Gregory Rose <gvrose8192@...il.com>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: net: Initialize return value in gro_cells_receive



On 10/6/20 8:53 PM, Gregory Rose wrote:
> The 'res' return value is uninitalized and may be returned with
> some random value.  Initialize to NET_RX_DROP as the default
> return value.
> 
> Signed-off-by: Greg Rose <gvrose8192@...il.com>
> 
> diff --git a/net/core/gro_cells.c b/net/core/gro_cells.c
> index e095fb871d91..4e835960db07 100644
> --- a/net/core/gro_cells.c
> +++ b/net/core/gro_cells.c
> @@ -13,7 +13,7 @@ int gro_cells_receive(struct gro_cells *gcells, struct sk_buff *skb)
>  {
>         struct net_device *dev = skb->dev;
>         struct gro_cell *cell;
> -       int res;
> +       int res = NET_RX_DROP;
> 
>         rcu_read_lock();
>         if (unlikely(!(dev->flags & IFF_UP)))

I do not think this is needed.

Also, when/if sending a patch fixing a bug, we require a Fixes: tag.

Thanks.