netdev - RE: [PATCH net-next 4/4] enetc: Migrate to PHYLINK and PCS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR04MB67547E9C44B1203314D5AF04960A0@AM0PR04MB6754.eurprd04.prod.outlook.com>
Date:   Wed, 7 Oct 2020 10:06:49 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Ioana Ciornei <ioana.ciornei@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: RE: [PATCH net-next 4/4] enetc: Migrate to PHYLINK and PCS_LYNX

>-----Original Message-----
>From: Ioana Ciornei <ioana.ciornei@....com>
>Sent: Tuesday, October 6, 2020 9:09 AM
[...]
>
>Shouldn't the driver reject any interface mode which it does not support?
>Either here in the validate callback or directly where the pf->if_mode is set.
>

Agreed on the 2 findings. v2 sent. Thanks Ioana.