netdev - RE: [PATCH] dpaa_eth: enable NETIF_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB39762E887745C2CAC34F9098EC0B0@AM6PR04MB3976.eurprd04.prod.outlook.com>
Date:   Thu, 8 Oct 2020 14:37:44 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>,
        Camelia Alexandra Groza <camelia.groza@....com>,
        Maxim Kochetkov <fido_max@...ox.ru>
Subject: RE: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> To: davem@...emloft.net
> Subject: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default
> 
> From: Maxim Kochetkov <fido_max@...ox.ru>
> 
> When packets are received on the error queue, this function under
> net_ratelimit():
> 
> netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
> 
> does not get printed. Instead we only see:
> 
> [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> [ 3669.085478] net_ratelimit: 228 callbacks suppressed
> 
> Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> about the frame descriptors of packets.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@...ox.ru>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index fdff3b4723ba..06cc863f4dd6 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -87,7 +87,7 @@ MODULE_PARM_DESC(tx_timeout, "The Tx timeout in ms");
> 
>  #define DPAA_MSG_DEFAULT (NETIF_MSG_DRV | NETIF_MSG_PROBE | \
>  			  NETIF_MSG_LINK | NETIF_MSG_IFUP | \
> -			  NETIF_MSG_IFDOWN)
> +			  NETIF_MSG_IFDOWN | NETIF_MSG_HW)
> 
>  #define DPAA_INGRESS_CS_THRESHOLD 0x10000000
>  /* Ingress congestion threshold on FMan ports
> --
> 2.25.1

Reviewed-by: Madalin Bucur <madalin.bucur@....nxp.com>