netdev - Re: [PATCH net-next] net/sched: get rid of qdisc->padded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXgjDwF0bO+vtJx7zqyApFRwkkL-qtakNCvwOp7c9pu3g@mail.gmail.com>
Date:   Wed, 7 Oct 2020 18:42:37 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Allen Pais <allen.lkml@...il.com>
Subject: Re: [PATCH net-next] net/sched: get rid of qdisc->padded

On Wed, Oct 7, 2020 at 9:51 AM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> kmalloc() of sufficiently big portion of memory is cache-aligned
> in regular conditions. If some debugging options are used,
> there is no reason qdisc structures would need 64-byte alignment
> if most other kernel structures are not aligned.
>
> This get rid of QDISC_ALIGN and QDISC_ALIGNTO.
>
> Addition of privdata field will help implementing
> the reverse of qdisc_priv() and documents where
> the private data is.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Cc: Allen Pais <allen.lkml@...il.com>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks.