netdev - Re: [net-next 1/3] i40e: Allow changing FEC settings on X722 if supported by FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201009163638.6d4c76bd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 9 Oct 2020 16:36:38 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Jaroslaw Gawin <jaroslawx.gawin@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: [net-next 1/3] i40e: Allow changing FEC settings on X722 if
 supported by FW

On Wed,  7 Oct 2020 16:10:48 -0700 Tony Nguyen wrote:
> +	if (hw->mac.type == I40E_MAC_X722 &&
> +	    !(hw->flags & I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE)) {
> +		netdev_err(netdev, "Setting FEC encoding not supported by firmware. Please update the NVM image.\n");
> +		return -EINVAL;

EOPNOTSUPP, since no FEC settings are supported by the device 
at the time of request.