lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Oct 2020 16:45:20 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Rohit Maheshwari <rohitm@...lsio.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com Subject: Re: [PATCH net v3] net/tls: sendfile fails with ktls offload On Thu, 8 Oct 2020 00:10:21 +0530 Rohit Maheshwari wrote: > At first when sendpage gets called, if there is more data, 'more' in > tls_push_data() gets set which later sets pending_open_record_frags, but > when there is no more data in file left, and last time tls_push_data() > gets called, pending_open_record_frags doesn't get reset. And later when > 2 bytes of encrypted alert comes as sendmsg, it first checks for > pending_open_record_frags, and since this is set, it creates a record with > 0 data bytes to encrypt, meaning record length is prepend_size + tag_size > only, which causes problem. > We should set/reset pending_open_record_frags based on more bit. > > Fixes: d829e9c4112b ("tls: convert to generic sk_msg interface") > Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com> Applied to net.
Powered by blists - more mailing lists