netdev - Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimUkSe489TibQsbUd2+BH-VHEoQw1cHhosni4C8EMWZog@mail.gmail.com>
Date:   Sun, 11 Oct 2020 14:13:04 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

On Sun, Oct 11, 2020 at 12:34 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote:
> > Currently, bp->msg_enable has default value of 0.  It is more useful
> > to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by
> > default.
> >
> > Reviewed-by: Edwin Peer <edwin.peer@...adcom.com>
> > Reviewed-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> > Signed-off-by: Michael Chan <michael.chan@...adcom.com>
>
> This will add whole bunch of output for "RX buffer error 4000[45]", no?
> That one needs to switch to a silent reset first, I'd think.

The last round of net-next patches have made changes to reduce this
noise already.  If the firmware supports the new  RING_MONITOR scheme,
There will be no more messages.  The reset will be counted in a new
ethtool -S counter only.

If the firmware is older and does not support the new scheme, we've
changed the logging to warn_once() in addition to the ethtool -S
counter.  There is no point in warning more than once.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4166 bytes)