netdev - Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201011145337.5264a0c2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 11 Oct 2020 14:53:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

On Sun, 11 Oct 2020 14:13:04 -0700 Michael Chan wrote:
> On Sun, Oct 11, 2020 at 12:34 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote:  
> > > Currently, bp->msg_enable has default value of 0.  It is more useful
> > > to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by
> > > default.
> > >
> > > Reviewed-by: Edwin Peer <edwin.peer@...adcom.com>
> > > Reviewed-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> > > Signed-off-by: Michael Chan <michael.chan@...adcom.com>  
> >
> > This will add whole bunch of output for "RX buffer error 4000[45]", no?
> > That one needs to switch to a silent reset first, I'd think.  
> 
> The last round of net-next patches have made changes to reduce this
> noise already.  If the firmware supports the new  RING_MONITOR scheme,
> There will be no more messages.  The reset will be counted in a new
> ethtool -S counter only.
> 
> If the firmware is older and does not support the new scheme, we've
> changed the logging to warn_once() in addition to the ethtool -S
> counter.  There is no point in warning more than once.

I'm talking about bnxt_dbg_dump_states specifically. 

I'm looking at net-next:

 bnxt_rx_pkt
   bnxt_sched_reset
     set_bit(BNXT_RESET_TASK_SP_EVENT, &bp->sp_event);


 bnxt_sp_task
   bnxt_reset
     bnxt_reset_task
       bnxt_dbg_dump_states