netdev - Re: [PATCH net-next 8/9] bnxt_en: Refactor bnxt_dl_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201011145938.7090b195@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 11 Oct 2020 14:59:38 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, gospo@...adcom.com,
        Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Subject: Re: [PATCH net-next 8/9] bnxt_en: Refactor bnxt_dl_info_get().

On Sun, 11 Oct 2020 06:23:00 -0400 Michael Chan wrote:
> +static int bnxt_dl_info_put(struct bnxt *bp, struct devlink_info_req *req,
> +			    enum bnxt_dl_version_type type, const char *key,
> +			    char *buf)
> +{
> +	if (!strlen(buf))
> +		return 0;

I think buf can be directly read from FW in later patches, it'd be good
to see a strnlen(), or bnxt_hwrm_nvm_get_dev_info() ensuring strings
are null-terminated.