netdev - Re: [PATCH] net: korina: free array used for rx/tx descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Oct 2020 14:37:33 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Valentin Vidic <vvidic@...entin-vidic.from.hr>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Philip Rischel <rischelp@....com>,
        Felix Fietkau <nbd@...nwrt.org>,
        Florian Fainelli <florian@...nwrt.org>,
        Roman Yeryomin <roman@...em.lv>,
        Jakub Kicinski <kuba@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...nel.org>,
        Martin Habets <mhabets@...arflare.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Network Development <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: korina: free array used for rx/tx descriptors

On Sun, Oct 11, 2020 at 7:46 AM Valentin Vidic
<vvidic@...entin-vidic.from.hr> wrote:
>
> Memory was not freed when driver is unloaded from the kernel.
>
> Signed-off-by: Valentin Vidic <vvidic@...entin-vidic.from.hr>

Makes sense.

Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")

Slightly off-topic, but I don't fully fathom what goes on with this
pointer straight after the initial kmalloc.

        lp->td_ring = (struct dma_desc *)KSEG1ADDR(lp->td_ring);

> ---
>  drivers/net/ethernet/korina.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
> index 03e034918d14..99146145f020 100644
> --- a/drivers/net/ethernet/korina.c
> +++ b/drivers/net/ethernet/korina.c
> @@ -1133,6 +1133,7 @@ static int korina_remove(struct platform_device *pdev)
>         iounmap(lp->eth_regs);
>         iounmap(lp->rx_dma_regs);
>         iounmap(lp->tx_dma_regs);
> +       kfree(lp->td_ring);
>
>         unregister_netdev(bif->dev);
>         free_netdev(bif->dev);

In general it is nice to release in reverse of acquire. But the driver
already does not follow this practice.