netdev - Re: [PATCH net-next 9/9] bnxt_en: Add stored FW version info to devlink info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAACQVJqHSom+d3Rjxjx0j6d4t6-O+8GUVE4y-cYbWKTyBVWUGQ@mail.gmail.com>
Date:   Mon, 12 Oct 2020 08:36:45 +0530
From:   Vasundhara Volam <vasundhara-v.volam@...adcom.com>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next 9/9] bnxt_en: Add stored FW version info to
 devlink info_get cb.

On Mon, Oct 12, 2020 at 4:01 AM Michael Chan <michael.chan@...adcom.com> wrote:
>
> On Sun, Oct 11, 2020 at 3:02 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Sun, 11 Oct 2020 06:23:01 -0400 Michael Chan wrote:
> > > +     rc = bnxt_hwrm_nvm_get_dev_info(bp, &nvm_dev_info);
> > > +     if (rc)
> > > +             return rc;
> >
> > This will not cause an error to be returned for the entire operation on
> > older FW or HW, right?
> >
>
> I don't think so.  This firmware call has been around for many years.
> The call was recently extended to return the stored version
> information but older firmware will still return successfully without
> the stored versions.  I'll ask Vasundhara to double check on this.
Yes, older firmware will return success and does not set the new flag
support for stored firmware versions. Only in error cases, older or
newer FW will return error. Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4182 bytes)