netdev - Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from device/AES-NI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201012030735.GA24873@gondor.apana.org.au>
Date:   Mon, 12 Oct 2020 14:07:35 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     poojatrivedi@...il.com, linux-crypto@...r.kernel.org,
        mallesh537@...il.com, josh.tway@...ckpath.com,
        netdev@...r.kernel.org
Subject: Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from
 device/AES-NI

On Fri, Oct 09, 2020 at 09:48:30AM -0700, Jakub Kicinski wrote:
>
> Are you saying that if we set CRYPTO_TFM_REQ_MAY_BACKLOG we should
> never see ENOSPC with a correctly functioning driver? Or do we need 
> to handle both errors, regardless?

Correct, you will never see ENOSPC if you request MAY_BACKLOG.
However, you must then ensure that when you get EBUSY that you
stop issuing new requests until the Crypto API signals through
the callback that you can start again.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt