netdev - Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Oct 2020 20:05:44 -0600
From:   David Ahern <dsahern@...il.com>
To:     Vlad Buslov <vlad@...lov.dev>, Jamal Hadi Salim <jhs@...atatu.com>
Cc:     David Ahern <dsahern@...il.com>, Vlad Buslov <vladbu@...dia.com>,
        stephen@...workplumber.org, xiyou.wangcong@...il.com,
        netdev@...r.kernel.org, davem@...emloft.net, jiri@...nulli.us,
        ivecera@...hat.com, Vlad Buslov <vladbu@...lanox.com>
Subject: Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump

On 10/9/20 9:38 AM, Vlad Buslov wrote:
> 
> On Fri 09 Oct 2020 at 15:45, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>> On 2020-10-09 8:15 a.m., Vlad Buslov wrote:
>>>
>>> On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>>
>>>> Which test(s)?
>>>> I see for example d45e mentioning terse but i dont see corresponding
>>>> code in the iproute2 tree i just pulled.
>>>
>>> Yes. The tests d45e and 7c65 were added as a part of kernel series, but
>>> corresponding iproute2 patches were never merged. Tests expect original
>>> "terse flag" syntax of V1 iproute2 series and will have to be changed to
>>> use -brief option instead.
>>
>> Then i dont see a problem in changing the tests.
>> If you are going to send a v3 please include my acked-by.
>> Would have been nice to see what terse output would have looked like.
>>
>> cheers,
>> jamal
> 
> Sure. Just waiting for everyone to voice their opinion regarding the
> output format before proceeding with any changes.
> 

go ahead and send a v3 with example output. cc Jamal and Cong