netdev - Re: [PATCH] net: usb: usbnet: update __usbnet_{read|write}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Oct 2020 08:14:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Anant Thazhemadam <anant.thazhemadam@...il.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Anant Thazhemadam <anant.thazhemadam@...il.com>,
        Oliver Neukum <oneukum@...e.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: usbnet: update  __usbnet_{read|write}_cmd() to
 use new API

Hi Anant,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.9 next-20201012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Anant-Thazhemadam/net-usb-usbnet-update-__usbnet_-read-write-_cmd-to-use-new-API/20201010-145950
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 6f2f486d57c4d562cdf4932320b66fbb878ab1c4
config: x86_64-randconfig-a005-20201012 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9e72d3eaf38f217698f72cb8fdc969a6e72dad3a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/77da62a1a1fcc73c3d8309c273dfd4d497918c6e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Anant-Thazhemadam/net-usb-usbnet-update-__usbnet_-read-write-_cmd-to-use-new-API/20201010-145950
        git checkout 77da62a1a1fcc73c3d8309c273dfd4d497918c6e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/usb/usbnet.c:1990:9: error: implicit declaration of function 'usb_control_msg_recv' [-Werror,-Wimplicit-function-declaration]
           return usb_control_msg_recv(dev->udev, 0,
                  ^
   drivers/net/usb/usbnet.c:1990:9: note: did you mean 'usb_control_msg'?
   include/linux/usb.h:1794:12: note: 'usb_control_msg' declared here
   extern int usb_control_msg(struct usb_device *dev, unsigned int pipe,
              ^
   drivers/net/usb/usbnet.c:2008:9: error: implicit declaration of function 'usb_control_msg_send' [-Werror,-Wimplicit-function-declaration]
           return usb_control_msg_send(dev->udev, 0,
                  ^
   drivers/net/usb/usbnet.c:2008:9: note: did you mean 'usb_control_msg'?
   include/linux/usb.h:1794:12: note: 'usb_control_msg' declared here
   extern int usb_control_msg(struct usb_device *dev, unsigned int pipe,
              ^
>> drivers/net/usb/usbnet.c:2010:26: error: use of undeclared identifier 'GPF_KERNEL'
                           USB_CTRL_SET_TIMEOUT, GPF_KERNEL);
                                                 ^
   3 errors generated.

vim +/GPF_KERNEL +2010 drivers/net/usb/usbnet.c

  1994	
  1995	static int __usbnet_write_cmd(struct usbnet *dev, u8 cmd, u8 reqtype,
  1996				      u16 value, u16 index, const void *data,
  1997				      u16 size)
  1998	{
  1999		netdev_dbg(dev->net, "usbnet_write_cmd cmd=0x%02x reqtype=%02x"
  2000			   " value=0x%04x index=0x%04x size=%d\n",
  2001			   cmd, reqtype, value, index, size);
  2002	
  2003		if (size && !data) {
  2004			WARN_ON_ONCE(1);
  2005			return -EINVAL;
  2006		}
  2007	
  2008		return usb_control_msg_send(dev->udev, 0,
  2009				cmd, reqtype, value, index, data, size,
> 2010				USB_CTRL_SET_TIMEOUT, GPF_KERNEL);
  2011	}
  2012	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (37241 bytes)