netdev - Re: vxlan_asymmetric.sh test failed every time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201014013916.GM2531@dhcp-12-153.nay.redhat.com>
Date:   Wed, 14 Oct 2020 09:39:16 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     Ido Schimmel <idosch@...lanox.com>,
        Network Development <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: vxlan_asymmetric.sh test failed every time

On Tue, Oct 13, 2020 at 10:49:30AM +0300, Ido Schimmel wrote:
> On Tue, Oct 13, 2020 at 12:39:43PM +0800, Hangbin Liu wrote:
> > Hi Ido,
> > 
> > When run vxlan_asymmetric.sh on RHEL8, It failed every time. I though that
> > it may failed because the kernel version is too old. But today I tried with
> > latest kernel, it still failed. Would you please help check if I missed
> > any configuration?
> 
> Works OK for me:
> 
> $ sudo ./vxlan_asymmetric.sh veth0 veth1 veth2 veth3 veth4 veth5
> TEST: ping: local->local vid 10->vid 20                             [ OK ]
> TEST: ping: local->remote vid 10->vid 10                            [ OK ]
> TEST: ping: local->remote vid 20->vid 20                            [ OK ]
> TEST: ping: local->remote vid 10->vid 20                            [ OK ]
> TEST: ping: local->remote vid 20->vid 10                            [ OK ]
> INFO: deleting neighbours from vlan interfaces
> TEST: ping: local->local vid 10->vid 20                             [ OK ]
> TEST: ping: local->remote vid 10->vid 10                            [ OK ]
> TEST: ping: local->remote vid 20->vid 20                            [ OK ]
> TEST: ping: local->remote vid 10->vid 20                            [ OK ]
> TEST: ping: local->remote vid 20->vid 10                            [ OK ]
> TEST: neigh_suppress: on / neigh exists: yes                        [ OK ]
> TEST: neigh_suppress: on / neigh exists: no                         [ OK ]
> TEST: neigh_suppress: off / neigh exists: no                        [ OK ]
> TEST: neigh_suppress: off / neigh exists: yes                       [ OK ]
> 
> # uname -r
> 5.9.0-rc8-custom-36808-gccdf7fae3afa
> 
> # ip -V
> ip utility, iproute2-5.8.0
> 
> # netsniff-ng -v
> netsniff-ng 0.6.7 (Polygon Window), Git id: (none)
> 
> The first failure might be related to your rp_filter settings. Can you
> please try with this patch?
> 
> diff --git a/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh b/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh
> index a0b5f57d6bd3..0727e2012b68 100755
> --- a/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh
> +++ b/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh
> @@ -215,10 +215,16 @@ switch_create()
>  
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 10
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 20
> +
> +       sysctl_set net.ipv4.conf.all.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan10-v.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan20-v.rp_filter 0
>  }
>  
>  switch_destroy()
>  {
> +       sysctl_restore net.ipv4.conf.all.rp_filter
> +
>         bridge fdb del 00:00:5e:00:01:01 dev br1 self local vlan 20
>         bridge fdb del 00:00:5e:00:01:01 dev br1 self local vlan 10
>  
> @@ -359,6 +365,10 @@ ns_switch_create()
>  
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 10
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 20
> +
> +       sysctl_set net.ipv4.conf.all.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan10-v.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan20-v.rp_filter 0
>  }
>  export -f ns_switch_create

Thanks a lot for help debugging this issue, this patch works for me.

Tested-by: Hangbin Liu <liuhangbin@...il.com>