netdev - Re: [PATCH bpf] bpf: selftest: Fix flaky tcp_hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzbFoFryfELodTeQPQdC_hR5o9rxCXwNd4y4Tu-xZyV-9A@mail.gmail.com>
Date:   Tue, 13 Oct 2020 14:59:00 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Networking <netdev@...r.kernel.org>,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH bpf] bpf: selftest: Fix flaky tcp_hdr_options test when
 adding addr to lo

On Tue, Oct 13, 2020 at 4:13 AM Martin KaFai Lau <kafai@...com> wrote:
>
> The tcp_hdr_options test adds a "::eB9F" addr to the lo dev.
> However, this non loopback address will have a race on ipv6 dad
> which may lead to EADDRNOTAVAIL error from time to time.
>
> Even nodad is used in the iproute2 command, there is still a race in
> when the route will be added.  This will then lead to ENETUNREACH from
> time to time.
>
> To avoid the above, this patch uses the default loopback address "::1"
> to do the test.
>
> Fixes: ad2f8eb0095e ("bpf: selftests: Tcp header options")
> Reported-by: Andrii Nakryiko <andriin@...com>
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---

Less shelling out is always good :)

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  .../bpf/prog_tests/tcp_hdr_options.c          | 26 +------------------
>  .../bpf/progs/test_misc_tcp_hdr_options.c     |  2 +-
>  2 files changed, 2 insertions(+), 26 deletions(-)
>

[...]