[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201015112822.adfl5kpgffgzi3wg@soft-test08>
Date: Thu, 15 Oct 2020 11:28:22 +0000
From: Henrik Bjoernlund <henrik.bjoernlund@...rochip.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <roopa@...dia.com>, <nikolay@...dia.com>,
<jiri@...lanox.com>, <idosch@...lanox.com>,
<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
<bridge@...ts.linux-foundation.org>,
<UNGLinuxDriver@...rochip.com>,
Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space
implementation of CFM. CCM frame RX added.
Thanks for your review. Comments below.
Regards
Henrik
The 10/14/2020 16:16, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Mon, 12 Oct 2020 14:04:24 +0000 Henrik Bjoernlund wrote:
> > +struct br_cfm_status_tlv {
> > + __u8 type;
> > + __be16 length;
> > + __u8 value;
> > +};
>
> This structure is unused (and likely not what you want, since it will
> have 2 1 byte while unless you mark length as __packed).
I have changed as requested.
--
/Henrik
Powered by blists - more mailing lists