[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201015112853.42vcj4bjbg7syoyd@soft-test08>
Date: Thu, 15 Oct 2020 11:28:53 +0000
From: Henrik Bjoernlund <henrik.bjoernlund@...rochip.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <roopa@...dia.com>, <nikolay@...dia.com>,
<jiri@...lanox.com>, <idosch@...lanox.com>,
<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
<bridge@...ts.linux-foundation.org>,
<UNGLinuxDriver@...rochip.com>,
Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH net-next v5 05/10] bridge: cfm: Kernel space
implementation of CFM. CCM frame TX added.
Thanks for your review. Comments below.
Regards
Henrik
The 10/14/2020 15:59, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Mon, 12 Oct 2020 14:04:23 +0000 Henrik Bjoernlund wrote:
> > + skb = dev_alloc_skb(CFM_CCM_MAX_FRAME_LENGTH);
> > + if (!skb)
> > + return NULL;
> > +
> > + rcu_read_lock();
> > + b_port = rcu_dereference(mep->b_port);
> > + if (!b_port) {
> > + rcu_read_unlock();
> > + return NULL;
> > + }
>
> At a quick scan I noticed you appear to be leaking the skb here.
> So let me point out some more nit picks.
I have changed as requested.
--
/Henrik
Powered by blists - more mailing lists