lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Oct 2020 07:20:51 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: Vlad Buslov <vlad@...lov.dev> Cc: Vlad Buslov <vladbu@...dia.com>, dsahern@...il.com, stephen@...workplumber.org, netdev@...r.kernel.org, davem@...emloft.net, xiyou.wangcong@...il.com, jiri@...nulli.us, ivecera@...hat.com, Vlad Buslov <vladbu@...lanox.com> Subject: Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump On 2020-10-16 12:42 p.m., Vlad Buslov wrote: > > All action print callbacks have arg==NULL check and return at the > beginning. To print action type we need either to have dedicated > 'brief_dump' callback instead of reusing print_aop() or extend/refactor > print_aop() implementation for all actions to always print the type > before checking the arg. What do you suggest? > Either one sounds appealing - the refactoring feels simpler as opposed to a->terse_print(). BTW: the action index, unless i missed something, is not transported from the kernel for terse option. It is an important parameter when actions are shared by filters (since they will have the same index). Am i missing something? cheers, jamal
Powered by blists - more mailing lists