netdev - Re: [PATCH iproute2-next 2/2] m_mpls: add mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Oct 2020 09:23:52 -0600
From:   David Ahern <dsahern@...il.com>
To:     Guillaume Nault <gnault@...hat.com>
Cc:     netdev@...r.kernel.org, martin.varghese@...ia.com
Subject: Re: [PATCH iproute2-next 2/2] m_mpls: add mac_push action

On 10/13/20 8:32 AM, Guillaume Nault wrote:
> @@ -41,12 +44,12 @@ static void usage(void)
>  
>  static bool can_modify_mpls_fields(unsigned int action)
>  {
> -	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MODIFY;
> +	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MAC_PUSH || action == TCA_MPLS_ACT_MODIFY;
>  }
>  
> -static bool can_modify_ethtype(unsigned int action)
> +static bool can_set_ethtype(unsigned int action)
>  {
> -	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_POP;
> +	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MAC_PUSH || action == TCA_MPLS_ACT_POP;
>  }
>  
>  static bool is_valid_label(__u32 label)

nit: please wrap the lines with the new action.

Besides the nit, very nice and complete change set - man page, help, and
 tests.