netdev - Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201017155751.4qtmrpf6mlrqptcs@skbuf>
Date:   Sat, 17 Oct 2020 18:57:51 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Kurt Kanzenbach <kurt@...utronix.de>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Richard Cochran <richardcochran@...il.com>,
        Kamil Alkhouri <kamil.alkhouri@...offenburg.de>,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann
 Hellcreek switches

On Fri, Oct 16, 2020 at 09:56:22AM -0700, Florian Fainelli wrote:
> I probably missed parts of this long discussion, but for this generation
> of switches, does that mean that you will only allow a bridge with
> vlan_filtering=1 to be configured and also refuse toggling of
> vlan_filtering at run time?

No, the bridge vlan_filtering option will be supported as both on or off.
The limitation that you're probably thinking of is that
NETIF_F_HW_VLAN_CTAG_FILTER will be non-optionally forced on. Otherwise
stated, ports in standalone mode will drop VLAN-tagged traffic unless
they have an 8021q upper with that VLAN ID. Which is probably ok
considering that the network stack would drop them anyway in absence of
an 8021q upper, but they won't be visible in tcpdump either, as things
stand. Otherwise stated, standalone hellcreek ports cannot support
promiscuous mode.
I know that currently DSA sets up NETIF_F_HW_VLAN_CTAG_FILTER as
forced-on for everybody, but that limitation could be lifted for some
switches, but not for hellcreek. Just something to keep in mind.