netdev - Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201021112838.3026a648@hermes.local>
Date:   Wed, 21 Oct 2020 11:28:38 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Petr Machata <me@...chata.org>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        dsahern@...il.com, john.fastabend@...il.com, jiri@...dia.com,
        idosch@...dia.com
Subject: Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS
 object

On Tue, 20 Oct 2020 22:43:37 +0200
Petr Machata <me@...chata.org> wrote:

> Jakub Kicinski <kuba@...nel.org> writes:
> 
> > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote:  
> >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets)
> >> +{
> >> +	print_string(PRINT_ANY, "cbs", "cbs %s ", ets->cbs ? "on" : "off");
> >> +}  
> >
> > I'd personally lean in the direction ethtool is taking and try to limit
> > string values in json output as much as possible. This would be a good
> > fit for bool.  
> 
> Yep, makes sense. The value is not user-toggleable, so the on / off
> there is just arbitrary.
> 
> I'll consider it for "willing" as well. That one is user-toggleable, and
> the "on" / "off" makes sense for consistency with the command line. But
> that doesn't mean it can't be a boolean in JSON.

There are three ways of representing a boolean. You chose the worst.
Option 1: is to use a json null value to indicate presence.
      this works well for a flag.
Option 2: is to use json bool.
	this looks awkward in non-json output
Option 3: is to use a string
     	but this makes the string output something harder to consume
	in json.