netdev - Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201021113234.56052cb2@hermes.local>
Date:   Wed, 21 Oct 2020 11:32:34 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Guillaume Nault <gnault@...hat.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        martin.varghese@...ia.com
Subject: Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth
 actions

On Mon, 19 Oct 2020 17:23:01 +0200
Guillaume Nault <gnault@...hat.com> wrote:

> +		} else if (matches(*argv, "pop_eth") == 0) {

Using matches allows for shorter command lines but can be make
for bad user experience if strings overlap.

For example 'p' here will match the pop_eth and not the push_eth.

Is it time to use full string compare for these options?