lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Oct 2020 21:04:33 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Cong Wang <xiyou.wangcong@...il.com> Cc: Guillaume Nault <gnault@...hat.com>, David Miller <davem@...emloft.net>, Linux Kernel Network Developers <netdev@...r.kernel.org>, Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, Po Liu <Po.Liu@....com> Subject: Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action() On Tue, 20 Oct 2020 17:37:22 -0700 Cong Wang wrote: > On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault <gnault@...hat.com> wrote: > > > > We need to jump to the "err_out_locked" label when > > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits > > with ->tcfa_lock still held. > > > > Fixes: d29bdd69ecdd ("net: schedule: add action gate offloading") > > Signed-off-by: Guillaume Nault <gnault@...hat.com> > > Looks like the err_out label can be just removed after this patch? > If any compiler complains, you have to fix it in v2, otherwise can be in a > separate patch. > > Other than this, > > Acked-by: Cong Wang <xiyou.wangcong@...il.com> Applied, thank you!
Powered by blists - more mailing lists