netdev - Re: [PATCH net] net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201020211240.04d005e3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 20 Oct 2020 21:12:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Davide Caratti <dcaratti@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...nulli.us>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Simon Horman <simon.horman@...ronome.com>,
        Shuang Li <shuali@...hat.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net/sched: act_tunnel_key: fix OOB write in case of
 IPv6 ERSPAN tunnels

On Tue, 20 Oct 2020 17:33:22 -0700 Cong Wang wrote:
> On Tue, Oct 20, 2020 at 3:03 PM Davide Caratti <dcaratti@...hat.com> wrote:
> >
> > the following command
> >
> >  # tc action add action tunnel_key \  
> >  > set src_ip 2001:db8::1 dst_ip 2001:db8::2 id 10 erspan_opts 1:6789:0:0  
> >
> > generates the following splat:  
> ...
> > using IPv6 tunnels, act_tunnel_key allocates a fixed amount of memory for
> > the tunnel metadata, but then it expects additional bytes to store tunnel
> > specific metadata with tunnel_key_copy_opts().
> >
> > Fix the arguments of __ipv6_tun_set_dst(), so that 'md_size' contains the
> > size previously computed by tunnel_key_get_opts_len(), like it's done for
> > IPv4 tunnels.  
> 
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thank you!