netdev - Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4eca7616-96bd-9fab-bf15-b03717753440@gmail.com>
Date:   Thu, 22 Oct 2020 08:11:45 -0600
From:   David Ahern <dsahern@...il.com>
To:     Guillaume Nault <gnault@...hat.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, martin.varghese@...ia.com
Subject: Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth
 actions

On 10/22/20 2:36 AM, Guillaume Nault wrote:
> 
>> Is it time to use full string compare for these options?
> 
> If there's consensus that matches() should be avoided for new options,
> I'll also follow up on this and replace it with strcmp(). However, that
> should be a clear project-wide policy IMHO.
> 

we can't change existing uses of 'matches'; it needs to be a policy
change going forward hence the discussion now.