netdev - Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201022142157.GA5100@pc-2.home>
Date:   Thu, 22 Oct 2020 16:21:57 +0200
From:   Guillaume Nault <gnault@...hat.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org, martin.varghese@...ia.com
Subject: Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth
 actions

On Thu, Oct 22, 2020 at 08:11:45AM -0600, David Ahern wrote:
> On 10/22/20 2:36 AM, Guillaume Nault wrote:
> > 
> >> Is it time to use full string compare for these options?
> > 
> > If there's consensus that matches() should be avoided for new options,
> > I'll also follow up on this and replace it with strcmp(). However, that
> > should be a clear project-wide policy IMHO.
> > 
> 
> we can't change existing uses of 'matches'; it needs to be a policy
> change going forward hence the discussion now.

Yes, that's what I meant. Sorry if I wasn't clear.