[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3cf2e7f8-7dc8-323f-0cee-5a025f748426@gmail.com>
Date: Wed, 21 Oct 2020 17:40:23 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Vladimir Oltean <olteanv@...il.com>,
Kurt Kanzenbach <kurt.kanzenbach@...utronix.de>
Cc: Christian Eggers <ceggers@...i.de>, Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Jakub Kicinski <kuba@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Helmut Grohne <helmut.grohne@...enta.de>,
Paul Barker <pbarker@...sulko.com>,
Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>,
George McCollister <george.mccollister@...il.com>,
Marek Vasut <marex@...x.de>,
Tristram Ha <Tristram.Ha@...rochip.com>,
"David S . Miller" <davem@...emloft.net>,
Woojung Huh <woojung.huh@...rochip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz
bindings document to yaml
On 10/21/2020 5:16 PM, Vladimir Oltean wrote:
> On Wed, Oct 21, 2020 at 08:52:01AM +0200, Kurt Kanzenbach wrote:
>> On Mon Oct 19 2020, Christian Eggers wrote:
>> The node names should be switch. See dsa.yaml.
>>
>>> + compatible = "microchip,ksz9477";
>>> + reg = <0>;
>>> + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
>>> +
>>> + spi-max-frequency = <44000000>;
>>> + spi-cpha;
>>> + spi-cpol;
>>> +
>>> + ports {
>>
>> ethernet-ports are preferred.
>
> This is backwards to me, instead of an 'ethernet-switch' with 'ports',
> we have a 'switch' with 'ethernet-ports'. Whatever.
The rationale AFAIR was that dual Ethernet port controllers like TI's
CPSW needed to describe each port as a pseudo Ethernet MAC and using
'ethernet-ports' as a contained allowed to disambiguate with the 'ports'
container used in display subsystem descriptions. We should probably
enforce or recommend 'ethernet-switch' to be used as the node name for
Ethernet switch devices though.
--
Florian
Powered by blists - more mailing lists