netdev - Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201023084425.22bbf069@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 23 Oct 2020 08:44:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hemant Kumar <hemantk@...eaurora.org>
Cc:     Loic Poulain <loic.poulain@...aro.org>, davem@...emloft.net,
        netdev@...r.kernel.org, manivannan.sadhasivam@...aro.org,
        eric.dumazet@...il.com, Jeffrey Hugo <jhugo@...eaurora.org>,
        Bhaumik Bhatt <bbhatt@...eaurora.org>
Subject: Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

On Thu, 22 Oct 2020 20:06:37 -0700 Hemant Kumar wrote:
> > @@ -1173,6 +1173,17 @@ int mhi_queue_buf(struct mhi_device *mhi_dev, enum dma_data_direction dir,
> >   }
> >   EXPORT_SYMBOL_GPL(mhi_queue_buf);
> >   
> > +bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction dir)
> > +{
> > +	struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> > +	struct mhi_chan *mhi_chan = (dir == DMA_TO_DEVICE) ?
> > +					mhi_dev->ul_chan : mhi_dev->dl_chan;
> > +	struct mhi_ring *tre_ring = &mhi_chan->tre_ring;
> > +
> > +	return mhi_is_ring_full(mhi_cntrl, tre_ring);
> > +}
> > +EXPORT_SYMBOL_GPL(mhi_queue_is_full);
> >   
> i was wondering if you can make use of mhi_get_free_desc() API (pushed 
> as part of MHI UCI - User Control Interface driver) here?

Let me ask you one more time. Where is this MHI UCI code you're talking
about?

linux$ git remote show linux
* remote linux
  Fetch URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
  Push  URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
  HEAD branch: master
  Remote branch:
    master tracked
linux$ git fetch linux
linux$ git checkout linux/master
HEAD is now at f9893351acae Merge tag 'kconfig-v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
linux$ git grep mhi_get_free_desc
linux$