netdev - Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a03293b6-71bb-50f7-870c-2db463e6499e@codeaurora.org>
Date:   Fri, 23 Oct 2020 10:19:44 -0600
From:   Jeffrey Hugo <jhugo@...eaurora.org>
To:     Jakub Kicinski <kuba@...nel.org>,
        Hemant Kumar <hemantk@...eaurora.org>
Cc:     Loic Poulain <loic.poulain@...aro.org>, davem@...emloft.net,
        netdev@...r.kernel.org, manivannan.sadhasivam@...aro.org,
        eric.dumazet@...il.com, Bhaumik Bhatt <bbhatt@...eaurora.org>
Subject: Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

On 10/23/2020 9:44 AM, Jakub Kicinski wrote:
> On Thu, 22 Oct 2020 20:06:37 -0700 Hemant Kumar wrote:
>>> @@ -1173,6 +1173,17 @@ int mhi_queue_buf(struct mhi_device *mhi_dev, enum dma_data_direction dir,
>>>    }
>>>    EXPORT_SYMBOL_GPL(mhi_queue_buf);
>>>    
>>> +bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction dir)
>>> +{
>>> +	struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
>>> +	struct mhi_chan *mhi_chan = (dir == DMA_TO_DEVICE) ?
>>> +					mhi_dev->ul_chan : mhi_dev->dl_chan;
>>> +	struct mhi_ring *tre_ring = &mhi_chan->tre_ring;
>>> +
>>> +	return mhi_is_ring_full(mhi_cntrl, tre_ring);
>>> +}
>>> +EXPORT_SYMBOL_GPL(mhi_queue_is_full);
>>>    
>> i was wondering if you can make use of mhi_get_free_desc() API (pushed
>> as part of MHI UCI - User Control Interface driver) here?
> 
> Let me ask you one more time. Where is this MHI UCI code you're talking
> about?

https://lkml.org/lkml/2020/10/22/186

-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.