lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Oct 2020 11:18:41 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Hangbin Liu <liuhangbin@...il.com> Cc: netdev@...r.kernel.org, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Eric Dumazet <eric.dumazet@...il.com>, "David S . Miller" <davem@...emloft.net>, Willem de Bruijn <willemdebruijn.kernel@...il.com> Subject: Re: [PATCHv3 net 2/2] IPv6: reply ICMP error if the first fragment doesn't include all headers On Fri, 23 Oct 2020 14:43:47 +0800 Hangbin Liu wrote: > diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c > index ec448b71bf9a..0bda77d7e6b8 100644 > --- a/net/ipv6/icmp.c > +++ b/net/ipv6/icmp.c > @@ -145,6 +145,7 @@ static bool is_ineligible(const struct sk_buff *skb) > int ptr = (u8 *)(ipv6_hdr(skb) + 1) - skb->data; > int len = skb->len - ptr; > __u8 nexthdr = ipv6_hdr(skb)->nexthdr; > + unsigned int offs = 0; > __be16 frag_off; > > if (len < 0) net/ipv6/icmp.c: In function ‘is_ineligible’: net/ipv6/icmp.c:148:15: warning: unused variable ‘offs’ [-Wunused-variable] 148 | unsigned int offs = 0; | ^~~~
Powered by blists - more mailing lists