netdev - Re: [RFC PATCH v1 1/6] net: phy: add CAN PHY Virtual Bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Oct 2020 22:18:07 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        David Jander <david@...tonic.nl>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Russell King <linux@...linux.org.uk>, mkl@...gutronix.de,
        Marek Vasut <marex@...x.de>, linux-can@...r.kernel.org
Subject: Re: [RFC PATCH v1 1/6] net: phy: add CAN PHY Virtual Bus

On Fri, Oct 23, 2020 at 12:56:21PM +0200, Oleksij Rempel wrote:
> Most of CAN PHYs (transceivers) are not attached to any data bus, so we
> are not able to communicate with them. For this case, we introduce a CAN
> specific virtual bus to make use of existing PHY framework.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  drivers/net/phy/Kconfig       |   8 ++
>  drivers/net/phy/Makefile      |   1 +
>  drivers/net/phy/can_phy_bus.c | 196 ++++++++++++++++++++++++++++++++++

Hi Oleksij

mdio drivers have moved to drivers/net/mdio.

>  include/linux/can/phy.h       |  21 ++++
>  4 files changed, 226 insertions(+)
>  create mode 100644 drivers/net/phy/can_phy_bus.c
>  create mode 100644 include/linux/can/phy.h
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 698bea312adc..39e3f57ea60a 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -153,6 +153,14 @@ config BCM_CYGNUS_PHY
>  config BCM_NET_PHYLIB
>  	tristate
>  
> +config CAN_PHY_BUS
> +	tristate "Virtual CAN PHY Bus"
> +	depends on PHYLIB
> +	help
> +	  Most CAN PHYs (transceivers) are not attached to any data bus, so we
> +	  are not able to communicate with them. For this case, a CAN specific
> +	  virtual bus to make use of existing PHY framework.

Is there anything CAN specific here? Maybe we should just call it a
virtual PHY bus?

	Andrew