netdev - Re: [PATCH -next] neigh: remove the extra slash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9bc6a8898116bc017152136265a523d5097da84.camel@perches.com>
Date:   Sat, 24 Oct 2020 19:27:10 -0700
From:   Joe Perches <joe@...ches.com>
To:     Vasily Averin <vvs@...tuozzo.com>,
        Zhang Qilong <zhangqilong3@...wei.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     lirongqing@...du.com, roopa@...ulusnetworks.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH -next] neigh: remove the extra slash

On Fri, 2020-10-23 at 13:16 +0300, Vasily Averin wrote:
> On 10/23/20 1:01 PM, Zhang Qilong wrote:
> > The normal path has only one slash.
> 
> it is not normal path
> this string is used to calculate number of symbols in "net/%s/neigh/%s" used below

Then probably better would be to add +1 rather than
use a rather odd filename.

> > diff --git a/net/core/neighbour.c b/net/core/neighbour.c
[]
> > @@ -3623,7 +3623,7 @@ int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p,
> >  	int i;
> >  	struct neigh_sysctl_table *t;
> >  	const char *dev_name_source;
> > -	char neigh_path[ sizeof("net//neigh/") + IFNAMSIZ + IFNAMSIZ ];
> > +	char neigh_path[sizeof("net/neigh/") + IFNAMSIZ + IFNAMSIZ];
> >  	char *p_name;
> >  
> > 
> >  	t = kmemdup(&neigh_sysctl_template, sizeof(*t), GFP_KERNEL);
> >