netdev - Re: [PATCH iproute2-next 3/5] lib: add libbpf support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91aed9d1-d550-cf6c-d8bb-e6737d0740e0@gmail.com>
Date:   Sun, 25 Oct 2020 16:12:34 -0600
From:   David Ahern <dsahern@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        Hangbin Liu <haliu@...hat.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>, David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        Jiri Benc <jbenc@...hat.com>,
        Andrii Nakryiko <andrii@...nel.org>
Subject: Re: [PATCH iproute2-next 3/5] lib: add libbpf support

On 10/25/20 9:13 AM, Toke Høiland-Jørgensen wrote:
> David Ahern <dsahern@...il.com> writes:
> 
>> On 10/22/20 9:38 PM, Hangbin Liu wrote:
>>> Note: ip/ipvrf.c is not convert to use libbpf as it only encodes a few
>>> instructions and load directly.
>>
>> for completeness, libbpf should be able to load a program from a buffer
>> as well.
> 
> It can, but the particular use in ipvrf is just loading half a dozen
> instructions defined inline in C - there's no object files, BTF or
> anything. So why bother with going through libbpf in this case? The
> actual attachment is using the existing code anyway...
> 

actually, it already does: bpf_load_program

I recalled figuring out how to do it, just did not remember if it was
local changes to libbpf. Does not look like any changes were needed:

https://github.com/dsahern/bpf-progs/blob/master/src/cgroup_sock.c