netdev - Re: [PATCH iproute2-next 3/5] lib: add libbpf support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Oct 2020 16:10:34 +0800
From:   Hangbin Liu <haliu@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Ahern <dsahern@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Jiri Benc <jbenc@...hat.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH iproute2-next 3/5] lib: add libbpf support

On Fri, Oct 23, 2020 at 05:21:20PM -0700, Andrii Nakryiko wrote:
> > +       obj = bpf_object__open_file(cfg->object, &open_opts);
> > +       if (IS_ERR_OR_NULL(obj))
> 
> libbpf defines libbpf_get_error() to check that the returned pointer
> is not encoding error, you shouldn't need to define your IS_ERR
> macros.

Thanks for this tip, I will fix it in next version.

Hangbin