netdev - Re: [PATCH v2 -next] neigh: Adjustment calculation method of neighbour path symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201026132436.3a57a98e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 26 Oct 2020 13:24:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zhang Qilong <zhangqilong3@...wei.com>
Cc:     <joe@...ches.com>, <vvs@...tuozzo.com>, <davem@...emloft.net>,
        <lirongqing@...du.com>, <roopa@...ulusnetworks.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 -next] neigh: Adjustment calculation method of
 neighbour path symbols

On Mon, 26 Oct 2020 10:21:26 +0800 Zhang Qilong wrote:
> Using size of "net//neigh/" is not clear, the use
> of stitching("net/" + /neigh") should be clearer.
> 
> Signed-off-by: Zhang Qilong <zhangqilong3@...wei.com>
> ---
>  net/core/neighbour.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 8e39e28b0a8d..0474e73c4f9f 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -3623,7 +3623,14 @@ int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p,
>  	int i;
>  	struct neigh_sysctl_table *t;
>  	const char *dev_name_source;
> -	char neigh_path[ sizeof("net//neigh/") + IFNAMSIZ + IFNAMSIZ ];
> +
> +	/*
> +	 * The path pattern is as follows
> +	 * "net/%s/neigh/%s", minusing one
> +	 * is for unnecessary terminators.
> +	 */
> +	char neigh_path[sizeof("net/") - 1 + IFNAMSIZ +
> +			sizeof("/neigh/") + IFNAMSIZ];

Let's leave this. The code is fine, the re-factoring is not worth the 
back an forth.

>  	char *p_name;
>  
>  	t = kmemdup(&neigh_sysctl_template, sizeof(*t), GFP_KERNEL);