lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Oct 2020 07:37:37 +1100 (AEDT) From: James Morris <jmorris@...ei.org> To: Jeff Vander Stoep <jeffv@...gle.com> cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, linux-security-module@...r.kernel.org, Roman Kiryanov <rkir@...gle.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] vsock: use ns_capable_noaudit() on socket create On Fri, 23 Oct 2020, Jeff Vander Stoep wrote: > During __vsock_create() CAP_NET_ADMIN is used to determine if the > vsock_sock->trusted should be set to true. This value is used later > for determing if a remote connection should be allowed to connect > to a restricted VM. Unfortunately, if the caller doesn't have > CAP_NET_ADMIN, an audit message such as an selinux denial is > generated even if the caller does not want a trusted socket. > > Logging errors on success is confusing. To avoid this, switch the > capable(CAP_NET_ADMIN) check to the noaudit version. > > Reported-by: Roman Kiryanov <rkir@...gle.com> > https://android-review.googlesource.com/c/device/generic/goldfish/+/1468545/ > Signed-off-by: Jeff Vander Stoep <jeffv@...gle.com> Reviewed-by: James Morris <jamorris@...ux.microsoft.com> -- James Morris <jmorris@...ei.org>
Powered by blists - more mailing lists