netdev - Re: [PATCHv2 iproute2-next 0/5] iproute2: add libbpf support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99d68384-c638-1d65-5945-2814ccd2e09e@gmail.com>
Date:   Wed, 28 Oct 2020 21:00:41 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <haliu@...hat.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        Jiri Benc <jbenc@...hat.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Toke Høiland-Jørgensen 
        <toke@...hat.com>
Subject: Re: [PATCHv2 iproute2-next 0/5] iproute2: add libbpf support

On 10/28/20 8:45 PM, Hangbin Liu wrote:
> On Wed, Oct 28, 2020 at 08:20:55PM -0600, David Ahern wrote:
>>>> root@...10-sfo3:~/iproute2.git# make -j 4
>>>> ...
>>>> /usr/bin/ld: ../lib/libutil.a(bpf_libbpf.o): in function `load_bpf_object':
>>>> bpf_libbpf.c:(.text+0x3cb): undefined reference to
>>>> `bpf_program__section_name'
>>>> /usr/bin/ld: bpf_libbpf.c:(.text+0x438): undefined reference to
>>>> `bpf_program__section_name'
>>>> /usr/bin/ld: bpf_libbpf.c:(.text+0x716): undefined reference to
>>>> `bpf_program__section_name'
>>>> collect2: error: ld returned 1 exit status
>>>> make[1]: *** [Makefile:27: ip] Error 1
>>>> make[1]: *** Waiting for unfinished jobs....
>>>> make: *** [Makefile:64: all] Error 2
>>>
>>> You need to update libbpf to latest version.
>>
>> nope. you need to be able to handle this. Ubuntu 20.10 was just
>> released, and it has a version of libbpf. If you are going to integrate
>> libbpf into other packages like iproute2, it needs to just work with
>> that version.
> 
> OK, I can replace bpf_program__section_name by bpf_program__title().

I believe this one can be handled through a compatability check. Looks
the rename / deprecation is fairly recent (78cdb58bdf15f from Sept 2020).


>>
>>>
>>> But this also remind me that I need to add bpf_program__section_name() to
>>> configure checking. I will see if I missed other functions' checking.
>>
>> This is going to be an on-going problem. iproute2 should work with
>> whatever version of libbpf is installed on that system.
> 
> I will make it works on Ubuntu 20.10, but with whatever version of libbpf?
> That looks hard, especially with old libbpf.
> 

I meant what comes with the OS. I believe I read that Fedora 33 was just
released as well. Does it have a version of libbpf? If so, please verify
it compiles and works with that version too. Before committing I will
also verify it compiles and links against a local version of libbpf (top
of tree) just to get a range of versions.