netdev - Re: [PATCHv2 iproute2-next 0/5] iproute2: add libbpf support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzY1gz2fR0DXOYgbheDArdYhWA66YRFuy=xMRveHTx=VVQ@mail.gmail.com>
Date:   Wed, 28 Oct 2020 19:50:51 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Hangbin Liu <haliu@...hat.com>, David Ahern <dsahern@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Jiri Benc <jbenc@...hat.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCHv2 iproute2-next 0/5] iproute2: add libbpf support

On Wed, Oct 28, 2020 at 7:34 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Wed, 28 Oct 2020 19:27:20 -0700
> Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:
>
> > On Wed, Oct 28, 2020 at 7:06 PM Hangbin Liu <haliu@...hat.com> wrote:
> > >
> > > On Wed, Oct 28, 2020 at 05:02:34PM -0600, David Ahern wrote:
> > > > fails to compile on Ubuntu 20.10:
> > > >
> > > > root@...10-sfo3:~/iproute2.git# ./configure
> > > > TC schedulers
> > > >  ATM  yes
> > > >  IPT  using xtables
> > > >  IPSET  yes
> > > >
> > > > iptables modules directory: /usr/lib/x86_64-linux-gnu/xtables
> > > > libc has setns: yes
> > > > SELinux support: yes
> > > > libbpf support: yes
> > > > ELF support: yes
> > > > libmnl support: yes
> > > > Berkeley DB: no
> > > > need for strlcpy: yes
> > > > libcap support: yes
> > > >
> > > > root@...10-sfo3:~/iproute2.git# make clean
> > > >
> > > > root@...10-sfo3:~/iproute2.git# make -j 4
> > > > ...
> > > > /usr/bin/ld: ../lib/libutil.a(bpf_libbpf.o): in function `load_bpf_object':
> > > > bpf_libbpf.c:(.text+0x3cb): undefined reference to
> > > > `bpf_program__section_name'
> > > > /usr/bin/ld: bpf_libbpf.c:(.text+0x438): undefined reference to
> > > > `bpf_program__section_name'
> > > > /usr/bin/ld: bpf_libbpf.c:(.text+0x716): undefined reference to
> > > > `bpf_program__section_name'
> > > > collect2: error: ld returned 1 exit status
> > > > make[1]: *** [Makefile:27: ip] Error 1
> > > > make[1]: *** Waiting for unfinished jobs....
> > > > make: *** [Makefile:64: all] Error 2
> > >
> > > You need to update libbpf to latest version.
> >
> > Why not using libbpf from submodule?
>
> Because it makes it harder for people downloading tarballs and distributions.

Genuinely curious, making harder how exactly? When packaging sources
as a tarball you'd check out submodules before packaging, right?

> Iproute2 has worked well by being standalone.

Again, maybe I'm missing something, but what makes it not a
standalone, if it is using a submodule? Pahole, for instance, is using
libbpf through submodule and just bypasses all the problems with
detection of features and library availability. I haven't heard anyone
complaining about it made working with pahole harder in any way.

>
> Want to merge libbpf into iproute2??

No... How did you come to this conclusion?..

>
>