netdev - [PATCH net-next v3] ne2k: Fix Typo in RW-Bugfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 15:33:57 +0100
From:   Armin Wolf <W_Armin@....de>
To:     kuba@...nel.org
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: [PATCH net-next v3] ne2k: Fix Typo in RW-Bugfix

Correct a typo in ne.c and ne2k-pci.c which
prevented activation of the RW-Bugfix.

Signed-off-by: Armin Wolf <W_Armin@....de>
---
v3 changes:
- do not enable the Bugfix by default
- change patch name

The reason for activating the Bugfix by default
was that a RealTek 8029AS nic caused symptoms
described in the original 8390 Datasheet as
beeing caused by the Read/Write-Bug, such as
sudden crashs, when the nic was in use.
But after further investigation, it seems that
the PSU is to blame for those problems, so there
is indeed no reason for activating the Bugfix by
default. Sorry for not noticing this sooner.
Nonetheless the discovered typos should be fixed,
since they prevent correct activation of the Bugfix
in both ne and ne2k-pci (even if noone seems to use
the Bugfix).

v2 changes:
- change NE8390_RW_BUGFIX to NE_RW_BUGFIX
---
 drivers/net/ethernet/8390/ne.c       | 2 +-
 drivers/net/ethernet/8390/ne2k-pci.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/8390/ne.c b/drivers/net/ethernet/8390/ne.c
index 1c97e39b478e..e9756d0ea5b8 100644
--- a/drivers/net/ethernet/8390/ne.c
+++ b/drivers/net/ethernet/8390/ne.c
@@ -710,7 +710,7 @@ static void ne_block_output(struct net_device *dev, int count,
 retry:
 #endif

-#ifdef NE8390_RW_BUGFIX
+#ifdef NE_RW_BUGFIX
 	/* Handle the read-before-write bug the same way as the
 	   Crynwr packet driver -- the NatSemi method doesn't work.
 	   Actually this doesn't always work either, but if you have
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
index bc6edb3f1af3..d6715008e04d 100644
--- a/drivers/net/ethernet/8390/ne2k-pci.c
+++ b/drivers/net/ethernet/8390/ne2k-pci.c
@@ -610,7 +610,7 @@ static void ne2k_pci_block_output(struct net_device *dev, int count,
 	/* We should already be in page 0, but to be safe... */
 	outb(E8390_PAGE0+E8390_START+E8390_NODMA, nic_base + NE_CMD);

-#ifdef NE8390_RW_BUGFIX
+#ifdef NE_RW_BUGFIX
 	/* Handle the read-before-write bug the same way as the
 	 * Crynwr packet driver -- the NatSemi method doesn't work.
 	 * Actually this doesn't always work either, but if you have
--
2.20.1