netdev - Re: [PATCH v8,net-next,12/12] crypto: octeontx2: register with linux crypto framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTScj_mRU0Eor2-_awn7s=AOAx_x57NOJscmmWV-BtwaFmA@mail.gmail.com>
Date:   Sat, 31 Oct 2020 14:54:35 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Srujana Challa <schalla@...vell.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        linux-crypto@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
        schandran@...vell.com, pathreya@...vell.com
Subject: Re: [PATCH v8,net-next,12/12] crypto: octeontx2: register with linux
 crypto framework

On Wed, Oct 28, 2020 at 5:43 PM Srujana Challa <schalla@...vell.com> wrote:
>
> CPT offload module utilises the linux crypto framework to offload
> crypto processing. This patch registers supported algorithms by
> calling registration functions provided by the kernel crypto API.
>
> The module currently supports:
> - AES block cipher in CBC,ECB,XTS and CFB mode.
> - 3DES block cipher in CBC and ECB mode.
> - AEAD algorithms.
>   authenc(hmac(sha1),cbc(aes)),
>   authenc(hmac(sha256),cbc(aes)),
>   authenc(hmac(sha384),cbc(aes)),
>   authenc(hmac(sha512),cbc(aes)),
>   authenc(hmac(sha1),ecb(cipher_null)),
>   authenc(hmac(sha256),ecb(cipher_null)),
>   authenc(hmac(sha384),ecb(cipher_null)),
>   authenc(hmac(sha512),ecb(cipher_null)),
>   rfc4106(gcm(aes)).
>
> Signed-off-by: Suheil Chandran <schandran@...vell.com>
> Signed-off-by: Srujana Challa <schalla@...vell.com>
> ---
>  drivers/crypto/marvell/Kconfig                |    4 +
>  drivers/crypto/marvell/octeontx2/Makefile     |    3 +-
>  .../marvell/octeontx2/otx2_cpt_reqmgr.h       |    1 +
>  .../marvell/octeontx2/otx2_cptvf_algs.c       | 1665 +++++++++++++++++
>  .../marvell/octeontx2/otx2_cptvf_algs.h       |  170 ++

These files are almost verbatim copies of
.../marvell/octeontx/otx_cptvf_algs.(ch), with the usual name changes
otx_ to otx2_

Is there some way to avoid code duplication? I guess this is not
uncommon for subsequent hardware device drivers from the same vendor.

If nothing else, knowing this makes reviewing a lot easier.