netdev - Re: [PATCH v8,net-next,11/12] crypto: octeontx2: add support to process the crypto request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSdVszdtPvpasE2FpZ97WRP1uV5UJMC5KjrnziTUY8UQOw@mail.gmail.com>
Date:   Sat, 31 Oct 2020 15:19:09 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Srujana Challa <schalla@...vell.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        linux-crypto@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
        schandran@...vell.com, pathreya@...vell.com
Subject: Re: [PATCH v8,net-next,11/12] crypto: octeontx2: add support to
 process the crypto request

On Wed, Oct 28, 2020 at 5:52 PM Srujana Challa <schalla@...vell.com> wrote:
>
> Attach LFs to CPT VF to process the crypto requests and register
> LF interrupts.
>
> Signed-off-by: Suheil Chandran <schandran@...vell.com>
> Signed-off-by: Srujana Challa <schalla@...vell.com>
> ---
>  drivers/crypto/marvell/octeontx2/Makefile     |   2 +-
>  .../marvell/octeontx2/otx2_cpt_common.h       |   3 +
>  .../marvell/octeontx2/otx2_cpt_reqmgr.h       | 145 +++++
>  drivers/crypto/marvell/octeontx2/otx2_cptlf.h |   7 +
>  .../marvell/octeontx2/otx2_cptvf_main.c       | 196 +++++++
>  .../marvell/octeontx2/otx2_cptvf_mbox.c       |  26 +
>  .../marvell/octeontx2/otx2_cptvf_reqmgr.c     | 532 ++++++++++++++++++
>  7 files changed, 910 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/crypto/marvell/octeontx2/otx2_cptvf_reqmgr.c


> +static int init_tasklet_work(struct otx2_cptlfs_info *lfs)
> +{
> +       struct otx2_cptlf_wqe *wqe;
> +       int i, ret = 0;
> +
> +       for (i = 0; i < lfs->lfs_num; i++) {
> +               wqe = kzalloc(sizeof(struct otx2_cptlf_wqe), GFP_KERNEL);
> +               if (!wqe) {
> +                       ret = -ENOMEM;
> +                       goto cleanup_tasklet;
> +               }
> +
> +               tasklet_init(&wqe->work, cptlf_work_handler, (u64) wqe);
> +               wqe->lfs = lfs;
> +               wqe->lf_num = i;
> +               lfs->lf[i].wqe = wqe;
> +       }
> +       return 0;
> +cleanup_tasklet:

nit: here and elsewhere, please leave an empty line between the return
statement and subsequent label.