netdev - Re: [PATCH net-next] r8169: remove unneeded memory barrier in rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201031163624.170499bd@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Sat, 31 Oct 2020 16:36:24 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: remove unneeded memory barrier in
 rtl_tx

On Thu, 29 Oct 2020 18:56:06 +0100 Heiner Kallweit wrote:
> tp->dirty_tx isn't changed outside rtl_tx(). Therefore I see no need
> to guarantee a specific order of reading tp->dirty_tx and tp->cur_tx.
> Having said that we can remove the memory barrier.
> In addition use READ_ONCE() when reading tp->cur_tx because it can
> change in parallel to rtl_tx().
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks!